Change of Error Code for Exception enum TryFrom<u8> impl #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vshailesh
commented
Sep 6, 2025
vshailesh
commented
- One of the ErrorCode had wrong Integer conversion in TryFrom implementation of Exception enum.
vshailesh
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
vshailesh
force-pushed
the
fix-exception-enum-bug
branch
from
678d6b5 to
46795cd
Compare
jprendes
approved these changes
Sep 6, 2025
|
@vshailesh , can you sign the commits? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Signed-off-by: Shailesh Vashishth <[email protected]>
vshailesh
force-pushed
the
fix-exception-enum-bug
branch
from
46795cd to
9ec5326
Compare
|
@jprendes I have signed the commit now, my gpg signature got removed after rebasing Regards |
|
Thanks @vshailesh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.